[Elgg 1.5-1.12 & 2.X - 4.X: Tidypics] v1.8.2

Release Notes

No longer beta! Apart from the things mentioned in the ToDo section everything should work. If not, please tell me.

Changes:

Rework of river activity settings (check the settings and make adjustments if necessary):

  • new option to set preview image size for all kind of Tidypics' river entries,
  • click on preview image in river now opens full size version of the image in a lightbox popup.
  • Under Features, when you say supports GD does that include automatic image file size compression?  I have always missed this feature with Tidypics  and offer my users a stand alone image file compressor before they upload to Tidypics. 

  • @jon666 The original uploaded image file is not modified (with the exception that the image orientation might get corrected if necessary by rotating the image). Regardless which image library is used (either GD or one of the other two provided that they are available on the server) they are only used to create the resized image thumbnails. The thumbnails are created in jpeg format which means there is some compression included implicitely because the jpeg format is a format that does image compression (with some amount of quality loss).

    If the uploaded images are smaller than the allowed max image size, there's nothing that prevents a user uploading a certain image. It's the user's choice how large the image file is as long as it's smaller than the max size. But as already mentioned, the images are likely to be already in a compressed image format and any additional compression would result in a loss of quality.

  • If i am not join to group i see upload photo button. When i try to upload photos from this button in group comes critical error. I dont know how to hide this button if you have no permission to upload photos in group.

  • @snbder I'll include the fix to hide the "Upload photos" button within groups for non-members of the group in the next release of Tidypics (though I don't know a release date yet).

    If you want to hide the upload button already now, you have to modify four files:

    • mod/tidypics/pages/photos/owner.php,
    • mod/tidypics/pages/photos/image/view.php,
    • mod/tidypics/pages/photos/album/view.php,
    • mod/tidypics/pages/lists/siteimagesgroup.php.

    With the modification the upload button will get hidden within the group context for non-members on the group albums page, the group photos page and when viewing an individual group album or a photo of a group album. The fix is the same for Tidypics 1.8.2 and 1.9.2.

    Within the files I listed above you'll see a if-clause that checks if the user is logged in and then the 'addphotos' menu item is registered within this if-clause. I include the whole, modified if-clause that you would have to replace the current code with in the following.

    In the file  mod/tidypics/pages/lists/siteimagesgroup.php the new code is:

    if (elgg_is_logged_in()) {
        if ($container->isMember(elgg_get_logged_in_user_entity())) {
            elgg_register_menu_item('title', array(
                'name' => 'addphotos',
                'href' => "ajax/view/photos/selectalbum/?owner_guid=" . $container_guid,
                'text' => elgg_echo("photos:addphotos"),
                'link_class' => 'elgg-button elgg-button-action elgg-lightbox'
            ));
        }
    }

    For the other three files the new code is the same:

    if (elgg_is_logged_in()) {
        if ($owner instanceof ElggGroup) {
            if ($owner->isMember(elgg_get_logged_in_user_entity())) {
                elgg_register_menu_item('title', array(
                    'name' => 'addphotos',
                    'href' => "ajax/view/photos/selectalbum/?owner_guid=" . $owner->getGUID(),
                    'text' => elgg_echo("photos:addphotos"),
                    'link_class' => 'elgg-button elgg-button-action elgg-lightbox'
                ));
            }
        } else {
            elgg_register_menu_item('title', array(
                'name' => 'addphotos',
                'href' => "ajax/view/photos/selectalbum/?owner_guid=" . elgg_get_logged_in_user_guid(),
                'text' => elgg_echo("photos:addphotos"),
                'link_class' => 'elgg-button elgg-button-action elgg-lightbox'
            ));
        }
    }

  • @iionly  Very big thanks!! It works! :)

  • I am having problems uploading photo from Iphones to tidypics. I am using Elgg 1.8.19. With the HTML5 upload the photos seem to upload but do not appear in the album. With the basic uploader their is an error displayed. Any help is appreciated.

  • Please has anyone any ideas why I see this after using the simple tidypics uploader,

    I am using 1.9 version

    But when I refresh the page, The image is in the gallery and displays fine.  ( There is more than this)

    Fatal Error.

    object_notifications is a private function and should not be called directly

    BadFunctionCallException Object
    (
    [message:protected] => object_notifications is a private function and should not be called directly
    [string:Exception:private] => exception 'BadFunctionCallException' with message 'object_notifications is a private function and should not be called directly' in /home/bluermnt/public_html/engine/lib/deprecated-1.9.php:3346

     

  • @hleroy What is the error displayed with the basic uploader? It's possible that the same problem also occurs with the html5 uploader even if there's no error displayed. Does the problem only occur when using an Iphone for uploading images?

    @radiostar It looks to me that you are using Elgg 1.9 but have not upgraded Tidypics to a version compatible with Elgg 1.9. Please update Tidypics to version 1.9.2 (https://community.elgg.org/plugins/385077/1.9.2/elgg-15-19-tidypics).

  • Thanks iionly. The error displayed as reported to me by a user was that there was a memory dysfunction. The iphone upload with the html5 system also did not go through but did not display an error message.

    However with an Android Galaxy phone the images uploaded properly.

    The problem occurred only when using an Iphone for uploading images.

  • @hleroy The memory error is likely to be caused by not enough memory being available for creation of the image thumbnails (and possibly correcting image orientation). This error would not be caused by using an Iphone for uploading the images (though if the images have been created on the Iphone itself the image orientation correction might be necessary additionally). The same error would also occur when trying to upload the same image from any other source. Though I have to check if the error message might not show up when using the html5 uploader as it should.

    Fixing the problem should be possible in two ways:

    • best would be to use either the ImageMagick tools or the Imagick php extension instead of the GD php extension as the image library to be used by Tidypics. Both alternatives have much lower memory requirements allowing handling of larger images (not necessarily image file size but first of all image resolution!). You should try to find out, if either of the alternative image libraries is an option for you. For both it's necessary that the corresponding package is installed on the server.
    • the second option would be increasing memory_limit - for example via Elgg's .htaccess file. But this option is no cure-all. Increasing memory_limit will allow for handling larger images but the limit will only be increased to slightly larger image resolutions. The GD php extension simply has quite large memory requirements. Therefore, option one is the better way if possible on the server

Stats

  • Category: Photos and Images
  • License: GNU General Public License (GPL) version 2
  • Updated: 2022-5-29
  • Downloads: 142560
  • Recommendations: 232

Other Projects

View iionly's plugins