[Elgg 1.5-1.12 & 2.X & 3.X: Tidypics] v1.8.1beta9

Release Notes

Changes for release 1.8.1beta9:

  • Fixed php syntax error introduced in beta8 preventing group profile pages to be rendered (thanks to Pasley70 for reporting).

Changes for release 1.8.1beta8:

  • Requires Elgg 1.8.16 due to bugfix https://github.com/Elgg/Elgg/issues/5564 for the pagination on list pages to work,
  • Pagination support for the list pages (like "Most views" / "Recently commented" etc.) to show more than only a hardcoded number of photos in each list view,
  • List pages (like "Most views" / "Recently commented" etc.) to work correctly when logged out and to show only photos that the viewer is allowed to see based on access level settings,
  • "All", "Friends", "Mine" tabs hidden on "All photos" page when logged-out,
  • "Upload photos" button hidden when logged-out,
  • "Photos you are tagged in" sidebar entry hidden when logged-out,
  • "Tag" entity menu entry hidden when logged out,
  • "Photos you are tagged in" page revised,
  • List of members tagged in a image in sidebar when viewing an image (by including a code snippet of the Tagged People plugin by Kevin Jardine),
  • Fix in image and album save actions for deleting all image/album tags to work (referring to the usual Elgg Entity tags),
  • Improvements in handling Tidypics user and word tags of images (including CSS improvements) to play well together with the image entity tags (avoiding double tags to be added, removal of corresponding image entity tags when an Tidypics image word tag is removed),
  • River entry on adding word tags to an image,

Includes the following changes in Tidypics from official Tidypics repo at https://github.com/cash/Tidypics:

  • made the albums notifications overridable rather than calling object_notifications() directly (by Cash Costello),
  • fixed: security issue with showing malicious exif data (by Jerome Bakker).
  • HI iionly.

    I'm using the 1.8.16 latest release. I upgraded from the tidypics 1.8rc1 to the beta9 and selected the upgrade button in the plugin settings. I am getting the issues as i mentioned above.

    On my other site i installed the beta9 virsion and everything seems to be working as it should.

    When i disable the tidypics beta9 plugin and remove the folder from mod Should everything go back to the way  before plugin installation and selecting the upgrade button?

    If this is the case then i may have to look at someof the other plugins enabled on the site for conflicts.

     

  • @clu55ter: if beta9 works correctly on your other site and there are differnt plugins installed you might want to check if any of these different plugins might be responsible for the problem. You might also want to try to copy the beta9 Tidypics folder again on your server. Maybe something went wrong the first time and some files are missing or incomplete (I assume you DID remove the old tidypics folder before installing the new folder outdated files not used anymore by beta9 could also result in problems).

    In case you want to downgrade there shouldn't be any problems. At least no problems caused by my version of Tidypics. But you might will find out that 1.8rc1 will not work on the recent versions of Elgg anymore (you won't be able to create new albums) and of course you will have to live will the the bugs still included that I have fixed in the meantime and without the functionality I've added (or made to work again)...

  • possibly this was mentioned previously..
    i am seeing many entries in the site log for tidypics images that are not being found..

    "PHP message: PHP Fatal error:  Call to a member function getThumbnail() on a non-object in /var/www/html/mysite/mod/tidypics/pages/photos/image/thumbnail.php on line 19

    when i view that file i see a 'todo' message.. ;)
    there is no support for handling missing images in the code yet.. maybe a default image needs to be returned instead?

  • @ura: the two things you mention (1: "to-do" and 2: missing images error message) are not directly connected. The "to-do" is in case thumbnail.php gets called with an GUID that does not belong to an Elgg entity. This should normally not happen. But I agree that the "to-do" should be fixed. :-) I'll think about the best way.

    The missing image error on line 19 is a result of re-sized images missing for a photo entry. In this case the "?" image is displayed instead. If there are no faulty photo entries on your site, this error should not occur. Could you check out what's wrong with any of the entries that results in the error? It would help me to know if the reason is really missing thumbnails or if the thumbnails are available (at least in the data directory) but not get displayed.

    I'm currently working on the next release trying to fix some issues that might result in faulty image uploads (out-of memory issues) and I will also include a way to remove faulty image entries via the admin backend. Unfortunately, I can't tell when I'll be finished as I've got only very few time to work on it currently and most of the time is spent on creating test cases that should provoke errors to happen...

  • i just viewed a faulty image on my local site and saw:

    Call to a member function getURL() on a non-object in /var/www/dev.mysite/mod/tidypics/views/default/object/image/navigation.php on line 20

    the page partially renders and css fails etc.

    i am not seeing the "?" message and as far as i saw when browsing the code, that is due to the 'todo' being called and not handled.

    i forgot to include in my previous message that there are also log references for :

    Call to a member function getImage() on a non-object in /var/www/html/mysite/mod/tidypics/pages/photos/image/thumbnail.php on line 17

    i searched my local site data directory for the guid of the image i attempted to view and there are no hits.
    i think possibly what occurred is that an error triggered some images to fail and then a few months ago i went through and manually ran php code to delete the images from elgg which is why the files/folders are not found.. however, for some reason the database still contains entity references for them.

    that description must surely be missing some details because otherwise that implies there are glitches with the delete() function.

    i just viewed the same image on my live site and with error logging enabled i see more info:

    Fatal error: Call to a member function getURL() on a non-object in /var/www/html/mysite/mod/tidypics/views/default/object/image/navigation.php on line 20 Call Stack: 0.0007 248984 1. {main}() /var/www/html/mysite/engine/handlers/page_handler.php:0 0.6382 19967776 2. page_handler() /var/www/html/mysite/engine/handlers/page_handler.php:46 0.6522 20077544 3. call_user_func() /var/www/html/mysite/engine/lib/pagehandler.php:53 0.6522 20077576 4. tidypics_page_handler() /var/www/html/mysite/engine/lib/pagehandler.php:53 0.6529 20102168 5. require('/var/www/html/mysite/mod/tidypics/pages/photos/image/view.php') /var/www/html/mysite/mod/tidypics/start.php:235 0.6748 20637224 6. elgg_view_entity() /var/www/html/mysite/mod/tidypics/pages/photos/image/view.php:70 0.6783 20676632 7. elgg_view() /var/www/html/mysite/engine/lib/views.php:854 0.7016 20809248 8. include('/var/www/html/mysite/mod/tidypics/views/default/object/image.php') /var/www/html/mysite/engine/lib/views.php:491 0.7016 20809512 9. elgg_view() /var/www/html/mysite/mod/tidypics/views/default/object/image.php:15 0.7022 20844344 10. include('/var/www/html/mysite/mod/tidypics/views/default/object/image/full.php') /var/www/html/mysite/engine/lib/views.php:491 0.8562 20975152 11. elgg_view() /var/www/html/mysite/mod/tidypics/views/default/object/image/full.php:53 0.8569 21004896 12. include('/var/www/html/mysite/mod/tidypics/views/default/object/image/navigation.php') /var/www/html/mysite/engine/lib/views.php:491

    the image is also not stored in the data folders on the live site

  • The "Call to a member function getURL() on a non-object" errors are most likely not due to images that have been deleted but due to faulty image uploads. I found a bug that had gone unnoticed in the 1.8 tidypics tree so far resulting in the check for available memory check for image resizing not working. This causes faulty image entries in case of large (regarding pixel size) images that would require more memory for resizing than available.

    Fixing this bug was not the main problem - I think I also improved the check in the meantime. But the whole chain of action on image uploads now needs a bit more re-writing and much testing (for all three options of image libraries: GD, imagick php extension and ImageMagick command line tools). If I would have had time for it during the last couple of weeks I most likely would have done that already but unfortunately I had not...

     

  • in the case of the images on my site, they did originally render ok as far as i know.. as i recall there was a point somewhere between elgg 1.7.4 and 1.8 that this issue began for these images.. i think the images were among the first that i uploaded to the elgg site (1.7.4).

  • just so you know.. here's another quite helpful potential enhancement to tidypics (and websites in general):

    https://mediacru.sh/
    https://github.com/MediaCrush/MediaCrush

    all images i have uploaded are shrunk and remain looking great. :)

  • @iionly: Thank you, as you mentioned in your reply, I looked at some of the plugins that was installed on my site and after disabling LiangLee Framework 1.1.5 and LiangLee Panel 1.0.1 plugins tidypics has started working as it should. I don't know if these plugins conflicted with tidypics but my photos are working after disabling them.

     

    Thanks

     

  • @clu55ter: there's a version 1.1.6 of LiangLee's framework plugin available. But I don't know what has changed and if it will resolve the issue in connection with Tidypics. Do you also need to disable the framework plugin or would it be enough to disable the Panel plugin only? If you also need to disable the framework plugin the problem might rather to be located there. Does everything else apart from Tidypics work when the framework and panel plugin are used? If not, there might be an issue within these plugins not directly connected with Tidypics. If yes, it might help to place Tidypics below these 2 other plugins in the plugin list in case you not already tried that.

  • HOw do i remove the error images that come out on photos all view..?

  • @LT: the memory issue is caused in a function that corrects image orientation on image upload. Currently, this function uses the GD library and therefore can fail for larger images. I'm already working on the next version that will fix this (for now I will only include a memory check and in case there's not enough memory is available the image orientation will not be changed. In the next step I will implement a image orientation correction that uses ImageMagick / Imagick php extension when available which should not have the same large memory footprint).

    I've already mostly finished the next release. It will also include a bugfix for image upload memory check for image resizing with GD library. The image resizing when using GD library and orientation correction were the reasons for the faulty image entries, so there shouldn't occur such faulty entries anymore with the next release.

    I will also include a "Delete image" tab on the Tidypics plugin settings page to allow for deletion of the faulty images. I hope I will have the next release finished until the end of the week.

    For now you could use the following code to delete faulty entries:

    <?php
    /**
     * Deletion of a Tidypics image (if image does not get properly displayed and delete button can not be reached)
     *
     * How to use:
     * - Copy this script into a the root directory of your Elgg installtion (name it for example "delete_tidypics_image.php"),
     * - note the GUID of the image you want to delete (this is the number included in the url of the image, e.g.
     *   http://site.url/photos/image/GUID/imagetitle)
     * - Call in browser: http://site.url/delete_tidypics_image.php?guid=GUID (replace GUID with the number you noted)
     *
     * Safety: this script can only be executed if you are logged in as admin. Otherwise it won't do anything. It will also delete only
     * a Tidypics image entity and nothing else.
     *
     * Please test with a single image first. If you don't get it working, don't try any further but first ask me why it might fail!!!
     *
     * iionly@gmx.de
     */

    require 'engine/start.php';

    if(!elgg_is_admin_logged_in()) {
        register_error("There's no admin logged in in this browser session.");
        forward(REFERER);
    }

    $guid = (int) get_input('guid');
    $entity = get_entity($guid);
    if (!$entity) {
        // unable to get Elgg entity
        register_error("There's no Elgg entity with this GUID.");
        forward(REFERER);
    }

    if (!$entity->canEdit()) {
        // user doesn't have permissions
        register_error("You need to be logged in as admin to be able to delete the image.");
        forward(REFERER);
    }

    $container = $entity->getContainerEntity();

    $subtype = $entity->getSubtype();
    switch ($subtype) {
        case 'image':
            $forward_url = $container->getURL();
            break;
        default:
            register_error("This GUID does not belong to a Tidypics image-entity. Deletion does not work.");
            forward(REFERER);
            break;
    }

    if ($entity->delete()) {
        system_message("The Tidypics image-entity was deleted.");
    } else {
        register_error("Deletion failed.");
    }

    forward($forward_url);

  • Ok thanks! Can't wait cause I have alot of mobile users and there unable to upload pics from phones..!

  • Dashboard shows "Most Recent images" widget photos in straight line going down and now arranging thunbnails according to box size..!  Is there a correction for this.?

    210.importedition.com

    tester/tester

  • @LT: I'm guessing with "Dashboard" you mean the index page, right? I see you are using a theme with a 3-column index page. Additionally the right column that includes the "Most recent images" widget is very small. Actually it's so small that no more than 1 image can be displayed in one row. The width of a single image entry in a widget is defined in the CSS file of Tidypics in the tidypics-gallery-widget class. It's set to 69px currently. I'm afraid it will not be possible to decrease this width any further and due to the width of the thumbnail images itself there's a minimum width necessary. The only possibility to improve the look of the "Most recent images" widget on your site if you want to keep it in the right column would be an increase of the width of the right column itself (in your theme). Or you could move the "Most recent images" widget in the wider middle column.

  • I can create a now folder but when i upload a Picture, he show me  - HTTP Error (302) an canceled.

    Where is the Problem???

  • @Christian: are you using the latest release (beta11)? I'm asking because you posted on the page of an earlier version.

    Does it happen with the Flash uploader, with the basic uploader or both? I'm suspecting the Flash uploader. Does it happen also when only uploading a single image? I had noticed that sometimes an upload might fail using the Flash uploader when switching directories when selecting the images to be uploaded. But I have not yet found out what exactly might be wrong. I'm afraid the only long-term solution to fix this issue might be to replace the Uploadify Flash uploader script used by Tidypics by somthing else. Right now I can only suggest to use the basic uploader instead if you don't have the same issue there, too.

  • Ohh sry, i have realy beta9.

    I try it with beta11

  • This plugin seems to do all it's asked to do. I'm building a site where photos will be a large part of the activity and on looking at the data folder I see there 3 different thumbs (mentioned elsewhere) plus the original.

    As many site users haven't got a clue, they will upload 3 meg photos and quickly burn up their quota. This wouldn't be a problem id the original photo was deleted once it's been converted into thumbs.

    My 1.5 meg test original was nicely converted into a 55kb thumb and the site continued to work fine when I deleted all originals from the data folder. Why then are the originals retained?

    Not being a programmer I may be speaking out of turn, but programming the script to delete the original once its been processed doesn't seem too complicated. In my case, it will allow users to upload hundreds more photos.

    Nice work.

  • @JohnK: as you posted not on the page of the latest release of the Tidypics plugins first the question: are you using beta11? If not, I would suggest to upgrade. While this won't change anything regarding the image files issue you asked about there are other fixes included.

    The original image file is kept for several reasons: first, people are allowed to download the original image (though this can be disabled via a plugin option). Secondly, the full size view of an image on site will display the original uploaded image. And lastly, in case the upload of an image worked but the following re-sizing of the image failed a site admin can re-do the re-sizing via the Tidypics plugin settings page. This won't be possible without the original image available.

    I also have not yet fully fixed the watermarking capabilities of the Tidypics plugin. When I have it working the way I have in mind an unmodified copy of the uploaded image without a watermark would be handy in some situations, too.

    The idea of removing the original image after re-sizing is still worth to think about. I imagine there could be a plugin setting added that controls if the original image should be kept or not. I'll keep that in mind and I might add such a feature sooner or later (depending on what might have to be changed to get such an option working without flaws).

    For now, you could either increase the quota or reduce the allowed maximum image filesize if the available disc space is a problem. Unfortunately, there's no other way right now.

  • iionly Thanks for the value update. Can you please tell me where can I uncomment the link under thumbnail album?

    Thanks in advance

    image

  • This "link" is the image title. I wonder why it gets displayed below the image on your site as it should be displayed above the image rather. Are you using the latest release of the Tidypics plugin (beta12)?

    I guess with "uncomment" you mean "not display it". Right? If yes, you can prevent the image title to be shown on the gallery pages by a change in mod/tidypics/views/default/object/image/summary.php. Change the last line from

    echo elgg_view_module('tidypics-image', $header, $body);

    to

    echo elgg_view_module('tidypics-image', '', $body);

  • Yes my friend, I use beta12 sorry to write here in this version. I don't know why the title is in the bottom, the point is that I try to not display title but I did what you tell me 

    echo elgg_view_module('tidypics-image', $header, $body);

    to

    echo elgg_view_module('tidypics-image', '', $body);

    and the title is still there :( 

  • I delete the whole summary.php and the title are still there I think that this way is not good for me

  • Deleting summary.php is wrong. This would result in the whole gallery view page to not work anymore. The only reason why it still works for you - and why the modification had no effect - is that some other plugin (e.g. your theme plugin) seems to override the summary view of Tidypics. This would also explain why the title is shown at the bottom instead on top of the images despite using beta12 because the view included in this other plugin is different in this aspect.

    You need to find out which other plugin is overriding the Tidypics summary view. Look in the folders of the other plugins if there's a file mod/<other plugin>/views/default/object/image/summary.php. Start with your theme plugin. If it's not the theme I can not make any good guess which other plugin it could be. For getting the image title hidden you would need to modify the view within the other plugin more or less in the same way as I explained above - but do not delete this view file and also restore the summary.php within the Tidypics plugin.

Stats

  • Category: Photos and Images
  • License: GNU General Public License (GPL) version 2
  • Updated: 2021-2-14
  • Downloads: 138016
  • Recommendations: 246

Other Projects

View iionly's plugins