[Elgg 1.5-1.12 & 2.X: Tidypics] v1.8.1beta12

Release Notes

Changelog:

  • Added placeholder images to be displayed in case no images have been uploaded to an album yet in the image sizes previously missing,
  • On deletion of an album the corresponding album folder in data directory gets deleted and no longer the (empty) album folder remains,
  • Flash uploader fixed in the case of group albums when someone else than the album creator wants to upload images to a group album,
  • Navigation arrows hidden if an album contains only a single image,
  • Correction of title of group pages "Most recent albums" widget,
  • "View all" link in Latest Photos widget on profile pages working for site visitors not logged in,
  • Fixed list of offered existing albums to select from for image uploads when in group context,
  • Fixed display of image and album gallery pages when images or albums exist that belong to groups with restricted access (The images or albums shown in the gallery pages depend on the viewing user having the necessary right for viewing depending on the access level defined for these albums including the images within these albums. For example a user gets to see all albums with "public" access level regardless if logged in or not. But if you set the access level "public" or "logged in" for a group album this results in even a non-group member being able to get access to such albums and their content. But if the group itself is a restricted group certain problems arise when this group contains "public" or "logged-in" content. In case of the gallery views within Tidypics the outcome is a fatal error occuring on these pages. This fix avoids the fatal error from happening. Still the group images and albums of restricted albums are included in the listings due to the access level set for them. If you don't want any albums or images of restricted groups to be seen by non-group-members you must set the access level of these albums to the corresponding group's level).
  • Thanks for this iionly, have a great 2014!

  • Hi iionly,

    I installed it after disabling and deleting previous folder, then flushed caches and upgraded. On first installation I also ran the upgrade command in this plugin's settings but in groups I see 2 links to group's photos.

    One si like this: mysite/photos/group/92693/all

    the other is: mysite/photos/siteimagesgroup/164252

     

    I guess one of them is from the original tidypics but I deleted the folder etc.

    Does anybody in the community see the same behaviour?

    Cheers!

  • @Michele: two entries in the sidebar of groups is correct. Also, the urls of these entries are correct. I guess you are confused because the button text for both entries is the same, right? This is then a problem caused by an incomplete or faulty language file provided by another plugin that overrides the correct language strings provided by the Tidypics plugin itself.

    The correct button text shown should be "Group photos" (mysite/photos/siteimagesgroup/164252) and "Group photo albums" (mysite/photos/group/92693/all) respectively. The orginal Tidypics had the button text "Group photos" for the entry linking to the group album page. So, if both buttons show the same text on your site it's either caused by an outdated translation (if not using English or German as site language) or if the same happens also for English or German some other plugin overrides the languages strings used for the buttons with a wrong text.

    Check out your language files (other plugins / language packs / site theme). Also, check the language strings showing up in the Translation editor plugin in case you are using it (which I wouldn't advice on a productive site).

  • Man...I need to sleep and relax....very SORRY for the stupid questions...I was checking within a group with no photos so thought that both links pointed to group photo albums but they do are correct and pointing to albums and single pictures altogheter...

    The confusion also depended on the original tidypics link....but no excuses for making you waste time again with me :'(

    One thing though: translation editor works great for me, why do you think not to be used on a production site?

    Cheers man and sorry again

  • @Michele:

    Personal preference of me: translating language files directly using a text editor. Comparing changes in language files when a new version of Elgg or a plugin gets released with diff and then merge the changes / update the translations also directly within the text editor. Testing the language files can be done on a local Elgg test installation to see the output "live". I don't see any advantage (for me) on using a plugin supporting the translations.

    As I said, it's a  personal preference not to use a plugin for translation works. But from an objective point of view using a translation plugin can result in the problem you experienced on your own with Tidypics: the translation plugin overrides the original language files (not necessarily taking the plugin order into account) which could result in trouble when upgrading Elgg or a plugin and the language file of the new version does not match the language strings in use by the Translation plugin.

    Between upgrading the plugin and then fixing the translations using the Translation plugin the "wrong" language output will be used. This is surely not good on a productive site as it might take some time until you are finished with upgrading the translations. Still, you can use a Translation plugin, if you prefer this approach. But I would suggest to prepare the translations (either with or without a Translation plugin) offline or using a test/development installation. Then you can take the language files (export them with the Translation plugin) and upload everything together with the new Elgg or plugin version at the same time on your productive server. You could either place your additional translations into the corresponding languages folder of Elgg or your plugin or you could create a separate plugin that holds all your custom language files. In the latter case there's also less trouble caused by the plugin priority as it's clearly defined which language file is used depending on the order of the plugin in the plugin list and there are no out-of-order effects caused by a Translation plugin that does not respect the plugin order.

  • Comment icon in river needs not to be shown (how?) when album commenting is disabled by the admin - if it is shown the user commets in the river in the album but it does not show up in the album page itself - confusion. Please see image. Thanks so much.image

  • Thanks for sharing your thoughts and suggestions iionly!

    Actually I never overwrite original (english) language files so always translating to empty ones and at the moment had no major issue with Translation Editor. Plus I always have backup copies ;)

    Cheers!

  • I tested more. 
    Apparently there are 3 scenarios :
    1 User can create an album with one or more photos
    2 User can upload one photo to an already created album
    3 User can upload more than one photos to an already created album

    If it is 2, clicking on comment icon in the river should show the comment both in river as well as under photo in the individual photo page

    If it is 1 or 3, and the admin has disabled album commenting, comment icon should not show in river

    When multiple photos are uploaded the river should show multiple photos together (7 or whatever is set as max) with comment disabled  BUT if one photo is uploaded comment can be made - is there any way to achieve this?

     

    Thanks

  • @kanha: right now I don't think that I will implement the handling of adding comments to images and albums depending on the number of images uploaded in one batch. This would only add more special cases depending also on the plugin settings used. It would not only be necessary to check on commenting where to add the comment to but also later it would have to be checked which comments to display below the entry. I think it would not only be complex to configure for the site admin but even more difficult to understand by the members who make the comments or read the comments of other. As I said "right now" that's my opinion. But I might change my mind because the handling of comments made on the activity page is something I'm currently in discussion with another developer by coincidence. I'm also not sure if the plugin option to disable comments on album pages will stay. Personally, I was never happy that this option was added. I would much prefer to simplify it again a bit and allow comments on album pages in any case.

    Stay tuned. It's in the flow right now. The next version of Tidypics should reveal the outcome.

  • @kanha: right now I don't think that I will implement the handling of adding comments to images and albums depending on the number of images uploaded in one batch. This would only add more special cases depending also on the plugin settings used. It would not only be necessary to check on commenting where to add the comment to but also later it would have to be checked which comments to display below the entry. I think it would not only be complex to configure for the site admin but even more difficult to understand by the members who make the comments or read the comments of other. As I said "right now" that's my opinion. But I might change my mind because the handling of comments made on the activity page is something I'm currently in discussion with another developer by coincidence. I'm also not sure if the plugin option to disable comments on album pages will stay. Personally, I was never happy that this option was added. I would much prefer to simplify it again a bit and allow comments on album pages in any case.

    Stay tuned. It's in the flow right now. The next version of Tidypics should reveal the outcome.

  • Thanks a lot iionly.

    I will just request to keep in mind the usual End-user behavior and expectancy in this case.

    The End-user (member, user etc) expectancy is really simple :
    If its multiple thumbnails in the river/activity stream, any comment made gets showed in the river/activty stream *and* below the album in the album page.
    If its one image in the river/activity stream, the comment gets showed in the river/activty stream *and* below the individual photo in the individual photo page

    In most scripts (buddypress, phpfox, oxwall) this is the default option with almost no chance of any complicated choice or messing by the admin. In real life also, like in facebook, this is the default behavior. Once again, the logic is really simple for the user to understand - if you are commenting below multiple photos, comment goes to no single photo but the entire album obviously. If you are commenting below a single photo the comment goes to that photo page.

  • fyi, i have been upgrading the highslide plugin.. basically it was a mess.

    i have brought it to elgg 1.8 level of code and cleaned it up. i found many bugs and have fixed them.

    i am currently optimising the code and expanding the admin panel options.. it's looking nice.

    i think highslide should replace the slideshow that is currently in tidypics.. there are others that may be nicer now - since highslide has not been updated for 2+ years. however, the results are still good and the code is almost ready to be used.

    i will upload the new code soon, once it is more complete. you can see an example on my live site here:
    https://www.infiniteeureka.com/photos/album/233/earthlings

  • @ura: I will follow your work on this with most interest. The slideshow script in Tidypics is something I want to see replace anyway as PiclensLite is not maintainted anymore and seems not to work anymore on Elgg 1.9 at all. I have found another slideshow script already but I've not yet found time to implement it. Maybe the highslide script could be used instead as you said.

  • i just found some glitches with highslide's animation / transitions - which i will look at fixing via the config file today.

    from what i am seeing, the highslide script is not being supported either.. so it is not a truly great solution.. and is more of a temporary improving to what is available in elgg currently. highslide does not support much css3 and i would like to have a pure css3 solution or close to that.

  • @ura: Highlslide not working on Elgg 1.9 could be caused by the change from fancybox to colorbox in Elgg 1.9. I'm suspecting that this change is also at least partly responsible for PiclensLite included in Tidypics not working anymore on Elgg 1.9.

    As I mentioned I want to replace the slideshow script with some other when I have time (dependency on Flash is not to my liking at all). I think the Galleria script looks very promising (http://galleria.io). I also found a responsive theme (http://gehrcke.de/galleria-classicmod/) for Galleria that looks very nice. There shouldn't be any license issues either. What I need to figure out for implementing this slideshow is how to provide the slideshow content (provided by Elgg as json array depending on the page including current page offset the slideshow is started from). Currently, I'm busy with other work though that seems a bit more urgent to deal with. So, I can't work on getting the slideshow replaced at the moment.

  • i haven't tested highslide in 1.9 yet.. the issues i am seeing are with 1.8 - i think this is due to the highslide code not being updated to recent browser spec levels.. the issues are relatively minor and the code is usable.. maybe i can improve the code in some ways.

    ah yes, the galleria code looks nice. so are you speaking of using the json file along with ajax loading?

    i have other issues to deal with too.. most likely i will refine highslide, load to github/community and then maybe come back to galleria soon; let me know when you are ready to look at it if i have not already let you know the same. ;)

  • Currently, PiclensLite gets the urls of a certain number of images via rss to include in the slideshow when called. With the urls not only of the currently views image but also the following the image preview panel is created. But you have to limit the number of images to a reasonable number to avoid memory issues. Therefore, the slideshow is likely to not include all images of an album (or other type of view like recently added images). There's currently also no dynamic adding of more images implemented once the end of the slideshow has been reached.

    The Galleria script allows for dynamic updates of the images included in the slideshow. It can handle json arrays with the urls of the images. What's necessary is to code it "the Elgg way", i.e. you have to retrieve the urls to be included in the json array via the Elgg API. I've not yet worked this out in all details. I think it should be possible to get it working though.

  • i don't know enough about ajax and json currently to comment much on this.. except that from what i comprehend currently, the galleria script is not coded to be ajax aware.. is that correct?
    they do mention a push() function in the reference text on their site though - maybe that is relevant - i'm not sure what the origin of that function is.

  • just found a glaring bug with tidypics..
    the friends' album view did not contain a tidypics-gallery element.
    when i looked at the page for that view i saw that the code there is incomplete.

    i also found that the friends list was only returning albums from 10 friends since the default for getFriends() is 10.. so i set the limit to 0 (seems not many people with many friends with images use elgg..) ;)


    i have created a fixed version. here's the code - that goes in /page/photos/friends.php - (after the line: set_input('list_type', 'gallery');)

     

    // get the user's friends' albums
    if (!$friends = $owner->getFriends('',0)) {
    $content = elgg_echo('friends:none:you');
    $content = '<div class="tidypics-gallery elgg-gallery">' . $content . '</div>';
    } else {


    $friendguids = array();
    foreach ($friends as $friend) {
    $friendguids[] = $friend->getGUID();
    }
    $content = elgg_list_entities(array(
    'type' => 'object',
    'subtype' => 'album',
    'owner_guids' => $friendguids,
    'full_view' => false,
    'list_type' => 'gallery',
    'list_type_toggle' => false,
    'gallery_class' => 'tidypics-gallery',
    'limit' => $limit,
    'offset' => $offset,
    ));
    if (!$content) {
    $content = elgg_echo('tidypics:none');
    $content = '<div class="tidypics-gallery elgg-gallery">' . $content . '</div>';
    }
    }

  • i also applied the same div wrapper with class tidypics-gallery for the empty content situation to the owner page, since there was the same issue there.

    for some themes the lack of a tidypics-gallery may not be a problem.. but on mine it is.

  • @ura: are you sure that this change in friends.php is necessary? You basically changed the whole code - and in the original code there wouldn't be any need to add a div either. Was your friends.php already different to the file included in this version of Tidypics here before you started to modify it?

    The limit parameter in list_user_friends_objects() (the function used in /pages/photos/friends.php included in the version of Tidypics you can download here) does not limit the number of friends but the number of items returned.

  • the limit i referred to is for getFriends(), not the function you mentioned.

    the changes are necessary, yes.

    the div is added since some mods add a div here and some haven't (such as tidypics) and i have used this div for styling since it is useful - see here: https://www.infiniteeureka.com/photos/all

    my version of friends.php is the version in this current version of the plugin - which i then modified yesterday.

  • @ura: the function get_friends() is not even used in /pages/photos/friends.php. The function used to retrieve the albums of friends is list_user_friends_objects() and there's no limit of the number of friends for this function (strictly speaking get_user_friends() which is called when executing list_user_friends_objects() has a limit of 999999 friends which should be enough).

    The format of the output friends' albums page is then created by the view views/default/object/album/gallery.php where elgg_view_module() uses the elgg-module-tidypics-album class.

  • aha, yes. you are correct.. i'm not sure what is occurring here then.. i made this change late last night after many hours coding.

    essentially i saw that some albums were not being displayed from a friend and decided, for some reason, that i would replace the code i replaced. and that did fix the issue.

    so i'm not sure why the original issue occurred then, but it definitely did occur - i applied several tests and every time there was a particular album missing.. until i changed the code as i did.

Stats

  • Category: Photos and Images
  • License: GNU General Public License (GPL) version 2
  • Updated: 2018-9-16
  • Downloads: 131015
  • Recommendations: 262

Other Projects

View iionly's plugins