Code Analyzer v1.0.3

Release Notes

  • Fixed issue with PHP versions lower than 5.4
  • Fixed 1.8 incompatibility
  • thanks for the fix.

    when i run this on 1.8 i now see a blank white box (where i think the results will be rendered) with no 'loader' animation..
    and after a few minutes i see: 

    • there was problem during request

  • @Pawel thanks, works great for me....actually too well...still many "problems" found! :D

    @ura At first try I experienced the same but then it worked by trying with a / or /mod in "Subdirectory to analyze"

    Cheers

  • This version is a bit heavier on computations, so it's possible that some timeout kicks in. Narrowing down the amount of files to analyze (by specifying subdirectory) should help.

    There were some changes in javascript in this version, so if you don't see ajax loader, it's possible that you need to clear the browser cache.

  • Hi Pawel,

    95% of problems for me is still in the core+bundled plugins.

    Do you think I should delete all files and folders in my installation (except data folder of course) and try again?

    I started from elgg 1.7 and then upgraded up to 1.8.16 and never deleted those files+folders just like when I upgrade plugins, basically because I never found anything suggesting that (except for some specific pugins' devs). Lately I've been suggested to do so...but of course that's quite scaring....what do you think?

    Cheers

  • Upgrading the site should involve replacing old core and bundled plugins code, not throwing new files over existing install. You want to remove files not used anymore and there was much restructurizing since 1.7. Probably that causes most of your errors as yo shouls expest only a few problems in case of 1.9, that are actually false positives (ie. Handling old parameters formats that is conditionally implemented in good functions.

    Upgrade shouldn't be scairy, as you should always keep backups and should be done on development server first - not directly on production site. I'd be more scared to run weird mix of two versions.

  • @Michele: if you backup your site (install folder, data dir & database) before cleaning up there should not be much to worry about. In case something breaks you would be able to restore the older state. You could also prepare the cleaned-up install folder in a parallel directory on your server (outside document root folder). Then you only need to move the content of this folder into your Elgg installation folder after you deleted the old content. As moving is faster than copying (especially much faster compated to uploading the files to the server) the time your site is offline will also be much shorter. Running upgrade.php after the cleaned-up install directory is in place will also help.

    Regarding the deprecated warnings in core files you will most likely not be able to get rid of all of them. Some functions that technically got deprecated are still necessary to allow for backward compatibility with existing plugins (otherwise they would stop working on the new Elgg release immediately). Though on Elgg 1.8 the core code might also not have been searched for deprecated functions as thoroughly as it might have been possible. On Elgg 1.9 the occurrence of deprecated functions in core should have been reduced to the absolute mininim though.

  • Guys, I now understand it clearly but....this is quite a major issue on the docs section.

    Please see point 3 here which is where everybody goes and learns http://docs.elgg.org/wiki/Upgrading_Elgg

    "overwrite" not delete and replace....what do you think?

    As a user I am authorized to think that some untouched files could not be in the new package because not in need to overwite anything. Therefore...

    Same thing for plugins, isn't it?

  • PS Pawel, iionly, of course I thank you very much for confirming and helping :)

  • BTW any feedback on code auto-fixing is very appreciated. Would like to know if it makes sense to dig into more complex fixing scenarios.

Paweł Sroka

Former Core Elgg team member, freelance developer.

Stats

  • Category: Tools
  • License: Expat (MIT) License
  • Updated: 2016-9-25
  • Downloads: 1843
  • Recommendations: 30

Other Projects

View Paweł Sroka's plugins