As for the question how to deal with libraries I thought that I had answered it back then sufficiently. If you, just tell what you are stuck with and I can try to explain it differently.
I tried upgrading one plugin to 3.x and I had several Fatal errors that I ended up just not upgrading plugins at all. The BC are not moving elgg forward, I mean no one is using RequireJS and here we are still using it.
Yet, somehow removing these libraries is actually good?
elgg_load_libraryactivity_profile_menuelgg_load_library
elgg-plugin.php
require_once(dirname(__FILE__) . '/lib/functions.php');
Bootstrap.php
use Elgg\Includer;
use Elgg\PluginBootstrap;
class Bootstrap extends PluginBootstrap {
protected function getRoot() {
return $this->plugin->getPath();
}
public function load() {
Includer::requireFileOnce($this->getRoot() . '/autoloader.php');
Includer::requireFileOnce($this->getRoot() . '/lib/functions.php');
}
...... activity_profile_menu
Where did you get it?
If it's a hook from /mod/groups:
elgg_register_plugin_hook_handler('profile_menu', 'profile', 'activity_profile_menu');You can use from /mod/activity:
elgg_register_plugin_hook_handler('register', 'menu:owner_block', '_elgg_activity_owner_block_menu');Or create own custom menu.
RequireJS
I don't understand what's wrong with it but you can look at this PR.
I don't understand what's wrong with it but you can look at this PR.
Well, Webpack does literally everything that requirejs does, and so much better:
By the way, AMD is so overrated. We should be using WebPack, or worst case Browserify.
Even WordPress has improved so much, without BC breaks. The new Gutenberg editor is modern, and still you can switch back to classic without any BC break.
I haven't encountered a problem like this before.
Maybe it has something to do with the setup (it being behind a reverse proxy)
- the site url configured in the site settings is correct (even http vs https matters). If for example the reverse proxy is handling the ssl encryption it'll send an http request to the webserver. However Elgg still needs to know it's https
- is the website installed in a subdirectory (like http://example.com/elgg/), then please check the RewriteBase in the .htaccess
PS: please check if you can update to Elgg 3.3 as Elgg 2.3 is in LTS and will not get any bugfixes anymore (except security fixes). See http://learn.elgg.org/en/stable/appendix/support.html
Let's start that these are cool plugins here.
Thank their authors for that.
"Downloads' and "Recommended" sections are mostly important for us (as developers).
It's an Elgg history.
And I don't support the idea of putting it away.
It's must be there.
But we can make a number of different categories for plugins depending on Elgg versions.
It's an idea.
@rjcalifornia
Let's me make a modern Elgg community based on Elgg 3.x and your and many users requestes.
Let's start that these are cool plugins here
Of course, at the time those were really awesome plugins. Now, those are dead plugins, without a developer behind them
Thank their authors for that.
Yes, they helped made what elgg is today. However, those are not working anymore.
It's an Elgg history.
"Downloads' and "Recommended" sections are mostly important for us (as developers)
Also for new people. They see the most recommended, download it and realize that it no longer works anymore. For example, WordPress has a neat featured and popular list (up to date):
https://wordpress.org/plugins/
https://wordpress.org/plugins/browse/featured/
https://wordpress.org/plugins/browse/popular/
But we can make a number of different categories for plugins depending on Elgg versions
That's an interesting idea. However, if we are following and recommending the elgg docs for the latest version, why is there such an interest to keep the old ones in most recommended/downloaded?
Let's me make a modern Elgg community based on Elgg 3.x and your and many users requestes.
I'm afraid that is gonna take a long time, there are more important issues at hand:
I support the idea of updating the addition, as it gives Elgg a lot of capabilities and makes it better, and there is also a lot of addition that did not happen since a big period. For example, version 3 does not have a little to add, even though it is the latest version, and it is assumed that it is the best and it is about to end and issue another version He still had a little bit of extra plug-in. I remember before, there was a lot of add-on 2 and a lot of updates. This made Elgg better.
info@elgg.org
Security issues should be reported to security@elgg.org!
©2014 the Elgg Foundation
Elgg is a registered trademark of Thematic Networks.
Cover image by Raül Utrera is used under Creative Commons license.
Icons by Flaticon and FontAwesome.