The previous discussion on markup went well. Next up is CSS. I'll try to capture the consensus in this top post as we discuss. There is obviously overlap between the two discussions. We'll wrap everything up in a guideline on the wiki/in svn when done.
CSS
info@elgg.org
Security issues should be reported to security@elgg.org!
©2014 the Elgg Foundation
Elgg is a registered trademark of Thematic Networks.
Cover image by RaĆ¼l Utrera is used under Creative Commons license.
Icons by Flaticon and FontAwesome.
I would support Cash's original proposal for underscores in ids. Dashes are actually illegal characters for ids in other contexts (eg. PHP variables) and using two different id syntax rules for a PHP app is confusing in my view.
I agree with underscores for class names. Of the reasons listed for using a dash, I think #2 is the only compelling one.
If we ever need to use the [attr|=val] selector, we're probably doing something wrong. Defining the rules using [attr|=val] for class="message-error" is more complex than class="message error". It's better to separate the classes out instead of string them together with a dash.
hi all,
I would also suggest to write a comprehensive documentation about ids and classes changes/removes/additions as the project evolves, in order to make easier the transition for those users who customized the actual default theme.
bye!
I hope the geneal view and the widget view are separated completely in Elgg 1.8. In Elgg 1.7, When I change the style of a plugin, it's widget style changed at the same time.
What is about displaying tiny mce depending on class or id instead to replace all textareas in elgg with tiny mce?
@alfalive - This is already in SVN for the 1.7.1 and 1.8.
This is very cool!!! :)
What if we want plain textareas w/o tinymce (mixed with tinymce textareas on the same page)?
@Evan - views/input/plaintext will do it.
@Brett - so now I'm confused. How is this different from what's going on now? What did alfalive mean by "all textareas" if plaintext (which outputs a textarea) doesn't have tinymce?
- Previous
- 1
- 2
- 3
- 4
- Next
You must log in to post replies.