As has been discussed on the community site, Elgg's XHTML, CSS, and UI could definitely be improved. As a starting place, I'd like to start a discussion on a guideline for XHTML. This guideline would be followed by core developers and serve as a good standard for plugin developers. The goal is better markup which makes it easier to do UI/UX work with Elgg.
What rules or recommendations would you like to see in an Elgg XHTML guideline? (Please note, this is for XHTML - not CSS. We'll get to CSS soon enough - edit - probably no way to keep them separate!).
XHTML
The CSS discussion is here.
info@elgg.org
Security issues should be reported to security@elgg.org!
©2014 the Elgg Foundation
Elgg is a registered trademark of Thematic Networks.
Cover image by RaĆ¼l Utrera is used under Creative Commons license.
Icons by Flaticon and FontAwesome.
Could we get some examples of simplfying the Elgg DOM? I know pulling out tables makes it cleaner but I'm looking for other examples.
A specific case that I remember is the river. Every item has a lot of unnecesary nested divs (in 1.5, I didn't use the following versions yet, maybe they were fixed). I remove most of them and they kept working fine.
And if I remember right, there are also a lot of unnecesary <p> enclosing some elements like inputs in forms and items in menus.
I will take a look for recovering more cases.
Now this is awesome. Standards compliance will make the platform much more atractive to designers & developers. I will try to help as much as I can!
@Cash Savvy use of CSS can help remove most of the excess divs wrapping the content, thus simplifying the DOM a lot.
@Morgar I really don't see the point in using XHTML Transitional. It's not very difficult to make things validate against the strict dtd, and it helps A LOT with misbehaving browsers (IE 7-)
@Federico: Yes, I agree strict is really not a big deal, I already used it in a couple of sites.
@All, fantastic to see this going on... not sure I understand all of it, but it will I think help make elgg the market leader it could be, and resolve my frustrations with it's clunkyness and complexity in theming and performance fears. Please keep it up!
I added a "Keep the DOM simple" item. The river is a good example of excessive markup - 6 divs and 1 paragraph tag for a single river entry.
Cool xhtml means that we get width and height for images code in future... :)
This is my vanilla install of Elgg 1.7, with the river overwriting the dashboard. This chunk is from the main content:
Based on what should be presented, here is my simplification of the DOM (I also have striped much of the JS, as these could more easily be targetted with jQuery selectors, but that's for another discussion.)
@morgar
This code in header produce many errors
@alfalive not sure what are you talking about. Do you mean that code produces errors running the w3 validator? For passing it, all '&' in urls must be changed to '&'. Validator generates many errors for every '&' ocurrence.
About the lines you mention, no, they are not equivalent, but I guess I didn't change the original one (in 1.5 version). I don't remember, I will check.
- Previous
- 1
- 2
- 3
- 4
- 5
- 6
- Next
You must log in to post replies.