River event : Elgg.org

River event

By ronnim 1516 days ago

Hello.

I'm trying to make the plugin hook [event: created, river] for Elgg 3:

elgg_register_event_handler('created', 'river', function (\Elgg\Event $event) {

      $item = $event->getObject();

      if ($item instanceof \ElggRiverItem) {

            elgg_log('test', 'ERROR');

     }

});

But this hook doesn't work.

I've enabled the error log and read the documentation http://learn.elgg.org/en/3.x/guides/events-list.html#river-events

I've also tested this in the Elgg core directly on https://github.com/Elgg/Elgg/blob/3.3/engine/lib/river.php#L303

But it seems to be not working either.
Has anyone been able to successfully use this hook?

ronnim 1516 days ago

Just to be clear I've tried this test in https://github.com/Elgg/Elgg/blob/3.3/engine/lib/river.php#L303:

function _elgg_river_update_object_last_action(\Elgg\Event $event) {

      $item = $event->getObject();

      if (!$item instanceof \ElggRiverItem) {
            return;
      }

      $object = $item->getObjectEntity();

      if ($object instanceof \ElggEntity) {
            $object->test = 'test';
            $object->save();
      }


      $target = $item->getTargetEntity();

      if ($target instanceof \ElggEntity) {
             $target->updateLastAction($item->getTimePosted());
      }
}

Then added a blog and checked it using the 'Inspect this entity' option.

Nothing (

- Jerome Bakker@jeabakker
Jerome Bakker 1515 days ago
- 1 like
The plugin where you're trying is active?
Have you flushed the caches?
When you added the blog did you also publish it, so it's not a draft? Because the river activity for blogs is only created during publishing.
- Nikolai Shcherbin@rivervanrain
Nikolai Shcherbin 1515 days ago
- 0 likes
Confirmed. This hook does nothing.
- ronnim@ronnim
ronnim 1515 days ago
- 0 likes
Hello, Jerome.
Yes, of course. I've done it all many times before.
- iionly@iionly
iionly 1515 days ago
- 1 like
It seems it's a bug in Elgg 3 within the elgg_create_river_item() function. The event gets triggered only at the very end of this function. But before these lines of codes are reached there's a check if the function was called with the return_item option set to true. I think this option is nowhere used in Elgg core for any river item creation. And with the option not being true (default is supposed to be false) the execution of the function never reaches the event trigger.
In Elgg 2 the code was different, i.e. the return_item option was checked only at the very end of the function after the event has been triggered. So, I would think a regression has been introduced in Elgg 3 resulting in the "created", "river" event no longer working.
The problem needs to be fixed in core, so I'll open an issue about it on github.
- Nikolai Shcherbin@rivervanrain
Nikolai Shcherbin 1515 days ago
- 1 like
Open PR
- Jerome Bakker@jeabakker
Jerome Bakker 1514 days ago
- 1 like
PR is merged, so in the next release of Elgg this will be fixed
- ronnim@ronnim
ronnim 1514 days ago
- 0 likes
Guys, thank you so much!
- Jerome Bakker@jeabakker
Jerome Bakker 1493 days ago
- 0 likes
Elgg 3.3.12 has been released with the fix.
https://elgg.org/blog/view/3073312/elgg-3312

River event

Beginning Developers

Navigation

Contact

Legal