I thought that had been fixed a long time ago... thanks for letting us know

I think I can't reproduce the error. So, it might be caused by group specific content (that I don't get to see but ura does).

Maybe the problem is indeed already fixed (PR merged) but the fix might just not be included in the latest available 2.1.1 yet as it came just immediately after that. Elgg 2.1.1 has been released quite some time ago after all.

No, I looked back and the github ticket is still open.  I started working on it but apparently never finished, and somehow convinced myself I had.

It's a problem of permissions and views.  A comment, or a discussion reply is accessible according to the access_id, but it's container is not.  This would be an old comment or discussion reply as they are now kept in sync, but the view just assumes if it's rendering a comment that the container is accessible, which is not strictly the case.

I don't get the error when I search logged in, presumably because I have access to the container.  Logged out I see the error.

I guess I looked at another PR then (https://github.com/Elgg/Elgg/pull/8062) as it closed https://github.com/Elgg/Elgg/issues/7984.

Yeah it was this one: https://github.com/Elgg/Elgg/issues/8103

The closed one is for keeping the access_id in sync, which fixes the issue for new content.  Legacy content that is out of sync we didn't upgrade, but ultimately the issue is that views are doing stuff like:

$container = $vars['entity']->getContainerEntity();

$container->someMethod();
 

Without checking that $container exists

@matt @iionly

Please check out this thread and give your options.

https://elgg.org/discussion/view/2506023/while-search-the-deactivated-plugin-content-is-showing-in-result-of-search