for a long while i have been receiving spurious emails from my site about videos held by videolist (elgg 1.8.18 version) when they should not be sent out.
i discovered that both of the view counter plugins (coldtrick's - https://github.com/ColdTrick/entity_view_counter and also matt's - http://community.elgg.org/plugins/872625/1.1/views-counter-18x) were triggering the messages every time the video was viewed. so i have disabled them for now.
i looked through the code briefly and got feedback from the coders - they pointed me back to videolist and i didn't see any obvious causes in the code for the view counter plugins.
today i just enabled etlikes (http://community.elgg.org/plugins/1161358/1.1/easytalkee-ajax-likes - ajax likes) plugin and the same issue occurred again when i liked a video in the river. (actually i didn't receive the notification but i immediately got an 'email undeliberable' notification from another user's hotmail account that had been sent a notification that i liked this video - even though there was no proper reason for that mail to be sent out.
so.. there is some type of bug somewhere either in core or in videolist that is triggering emails incorrectly (or possibly in some other notification plugin i am using).
does anyone have any thoughts on the cause of this?
coldtrick advised me to use this version of videolist to test: https://github.com/Pleio/videolist
i haven't done that yet and do not know what the possible fix is that may be in it.
thanks
info@elgg.org
Security issues should be reported to security@elgg.org!
©2014 the Elgg Foundation
Elgg is a registered trademark of Thematic Networks.
Cover image by Raül Utrera is used under Creative Commons license.
Icons by Flaticon and FontAwesome.
so i removed these two event handlers and so far the bug appears to be resolved and there is no apparent loss of functionality.. so i am confused as to why the events were in there at all.
i also notice that the videolist notification code is very basic and could be greatly improved if it used the same format approach as other plugins.
oh ok, so these changes are already included in this version of videolist:
https://github.com/Pleio/videolist/blob/master/start.php
that is the version i had been using, yes - http://community.elgg.org/plugins/814895/1.8.1/videolist (same one)
the pleio version has several fixes in it relating to notifications - i am testing it now.
the pleio version also has some bugs in it - mainly formatting issues. i am looking now to find which version to use as the basis for a functional version.
- Previous
- 1
- 2
- Next
You must log in to post replies.