Ticket #361 (closed defect: fixed)

Opened 6 months ago

Last modified 5 months ago

variable not declared in proper scope in mod/newsclient/lib.php - causes error if no feeds

Reported by: edfactor Assigned to: nobody
Priority: normal Milestone: 0.9.2
Component: plugins Version: 0.9.1
Severity: normal Keywords:
Cc: Patch Included: 1
Review Stage: readyforcheckin

Description

In the lib.php file of newsclient module, on line 139, the function: newsclient_widget_display($widget)

defines the $title variable in the if, but not the else. If you go through the else (if there are no feeds), you get an undefined variable error for the last line. I added an empty definition at the beginning of the function so that this would not happen.

Attachments

newsclientlib.diff (414 bytes) - added by edfactor on 06/05/08 15:12:51.
Diff file for this ticket

Change History

06/05/08 15:12:51 changed by edfactor

  • attachment newsclientlib.diff added.

Diff file for this ticket

06/09/08 07:31:07 changed by misja

  • status changed from new to closed.
  • resolution set to fixed.
  • review_stage changed from unreviewed to readyforcheckin.

Patch applied in r1597