Ticket #357 (closed enhancement: fixed)

Opened 6 months ago

Last modified 5 months ago

Search of usernames

Reported by: justinr Assigned to: nobody
Priority: normal Milestone: 0.9.2
Component: search Version: 0.9.1
Severity: normal Keywords:
Cc: Patch Included: 1
Review Stage: readyforcheckin

Description

The enclosed patch will enable Elgg to search over usernames (users.username) in addition to names (users.name). Additionally, it uses the icon-based results display consistent with the profile plugin (since that's where I copied it from, after all).

Note that I turned off the catch clause at the top that uses the MATCH...AGAINST syntax if we're on MySQL. MATCH...AGAINST doesn't do sub-word substring searches, so it really shouldn't be used on matching names. For example, you can't search for "just" and come up with "justin" as a result. Hence the move to the LIKE syntax instead. I've left the old code in this patch, but maybe it ought to be taken out entirely; that's your call.

Attachments

search-username.diff (2.9 kB) - added by justinr on 05/21/08 18:25:45.
search enhancements [with fixed typo]

Change History

05/21/08 18:25:45 changed by justinr

  • attachment search-username.diff added.

search enhancements [with fixed typo]

06/09/08 08:02:45 changed by misja

  • status changed from new to closed.
  • resolution set to fixed.
  • review_stage changed from unreviewed to readyforcheckin.

Patch applied in r1603

06/13/08 19:57:32 changed by justinr

  • status changed from closed to reopened.
  • resolution deleted.

The whole patch didn't get applied. For some reason, only the formatting made it into r1603 and the part that actually changes the search functionality (to allow for matches against username and partial matches against name) got left out. I'm reopening the ticket so that this can be reviewed.

06/17/08 08:42:05 changed by misja

  • status changed from reopened to closed.
  • resolution set to fixed.

patch fully applied in r1606, if all is well