Ticket #343 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Notification errors in community join

Reported by: kevin Assigned to: nobody
Priority: normal Milestone: 0.9.2
Component: core Version: 0.9.0
Severity: normal Keywords:
Cc: Patch Included: 0
Review Stage: reviewed

Description

In the file /mod/community/lib/community_member_add.php, line 29, there is an erroneous check for email notifications. The code within this check is only executed if the person has email notification turned on.

In fact, this code should always get executed. Because of this error, community owners only receive notification of new memners if they have emial notification turned on, and even more importantly, a "community:member" publish event is triggered only if the owner of the community happens to have email notification turned on.

To fix this problem, comment out or remove the begiining of the if (line 29) and the end of the if (line 34).

Change History

(in reply to: ↑ description ) 04/19/08 12:07:06 changed by kevin

Replying to kevin:

This report should have said "The code within this check is only executed if the *community owner* has email notification turned on."

04/22/08 08:05:33 changed by misja

  • status changed from new to closed.
  • resolution set to fixed.
  • review_stage changed from unreviewed to reviewed.

Fixed in r1583 - thanks Kevin