Ticket #183 (new enhancement)

Opened 1 year ago

Last modified 6 months ago

Do mutual friendship when user has moderate flag

Reported by: rho Assigned to: rho
Priority: normal Milestone: 0.9.3
Component: core Version: 0.8.1
Severity: normal Keywords: friendship
Cc: misja,ewout Patch Included: 0
Review Stage: consider

Description

1. user A has moderate friendship flag 2. user B request friendship of user A 3. user A accepts friendship of user B

As elgg has dual-way of friendship, on step 3 B is friend of A, but A is not friend of B. Also B will not see activity of A.

Must elgg do mutual friendship when user has moderate flag?

Attachments

030_friendship_actions_cleanup.diff (8.6 kB) - added by rho on 11/30/07 18:54:06.

Change History

11/30/07 18:54:06 changed by rho

  • attachment 030_friendship_actions_cleanup.diff added.

12/03/07 11:07:24 changed by misja

Patch looks good. I don't think there should be a mutual friendship if the moderate flag is active, it's up to the user to decide.

12/07/07 22:44:48 changed by rho

  • milestone deleted.

01/25/08 18:13:51 changed by ewout

  • haspatch changed.
  • type changed from defect to enhancement.
  • review_stage set to consider.

I agree with Misja, the part of the patch which implements the automatic reciprocal friendship maybe could be enhanced / changed to a choice or form presented to user A, asking whether he/she wants to reciprocate the request.

But is it not enough to simply present an easy way to go the users B profile? User A can always click the friendship link there.

01/25/08 19:17:41 changed by ewout

  • milestone set to 1.0.

christianh says in #280 (marked as duplicate of this one):

Admin should have the option to configure via admin panel or config file whether the adding of friends should be reciprocal, or not.

If enabled, friend A could add friend B, a friend request would be sent to friend B. upon acceptance of the friend request, friend A would be added to friend B's friends list and vice-versa.

03/13/08 11:26:31 changed by

  • milestone deleted.

Milestone 1.0 deleted

03/13/08 11:30:13 changed by misja

  • milestone set to 0.9.3.

05/21/08 14:49:45 changed by markpea

If I wanted reciprocal friending to be automatic when moderate flag is set would the code posted at http://classic.elgg.org/mod/vanillaforum/vanilla/comments.php?DiscussionID=1716 do the job? Markpea